Add ProcessSnapshotMac

Add ProcessSnapshotMac.

R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/279ca87e68d80e6f858483bacb10bd7249b389d0

[Mark Mentovai, 2014-10-14 21:56:17]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-10-14 21:56:44]

This doesn’t have its own test because of bug 2. This just wraps existing
well-tested code.

This depends on https://codereview.chromium.org/649633004/.

[Robert Sesek, 2014-10-15 20:53:05]

https://codereview.chromium.org/650223007/diff/1/snapshot/process_snapshot_ma...
File snapshot/process_snapshot_mac.cc (right):

https://codereview.chromium.org/650223007/diff/1/snapshot/process_snapshot_ma...
snapshot/process_snapshot_mac.cc:65: if
(!exception_->Initialize(&process_reader_,
You could report the result out of this method, too. Not sure that'd be useful,
though.

https://codereview.chromium.org/650223007/diff/1/snapshot/process_snapshot_ma...
snapshot/process_snapshot_mac.cc:111: for (internal::ThreadSnapshotMac* thread :
threads_) {
You could use more auto here and in the loops below, if you wanted.

[Mark Mentovai, 2014-10-15 21:36:21]

Updated.

https://codereview.chromium.org/650223007/diff/1/snapshot/process_snapshot_ma...
File snapshot/process_snapshot_mac.cc (right):

https://codereview.chromium.org/650223007/diff/1/snapshot/process_snapshot_ma...
snapshot/process_snapshot_mac.cc:111: for (internal::ThreadSnapshotMac* thread :
threads_) {
Robert Sesek wrote:
> You could use more auto here and in the loops below, if you wanted.

I still think it’s kind of nice to see the type written out where it’s known and
not cumbersome. I’ve been saving auto for cases where the type is difficult to
know or difficult to parse.

(And I think you’ve asked me to change auto to not be auto in the past…)

[Robert Sesek, 2014-10-15 22:35:50]

LGTM

https://codereview.chromium.org/650223007/diff/1/snapshot/process_snapshot_ma...
File snapshot/process_snapshot_mac.cc (right):

https://codereview.chromium.org/650223007/diff/1/snapshot/process_snapshot_ma...
snapshot/process_snapshot_mac.cc:111: for (internal::ThreadSnapshotMac* thread :
threads_) {
On 2014/10/15 21:36:21, Mark Mentovai wrote:
> Robert Sesek wrote:
> > You could use more auto here and in the loops below, if you wanted.
> 
> I still think it’s kind of nice to see the type written out where it’s known
and
> not cumbersome. I’ve been saving auto for cases where the type is difficult to
> know or difficult to parse.
> 
> (And I think you’ve asked me to change auto to not be auto in the past…)

I figured that's why you didn't, which is why I phrased it as optional. Fine to
not use auto here.

[Mark Mentovai, 2014-10-17 16:29:33]

Updated for https://codereview.chromium.org/650223007.

[Mark Mentovai, 2014-10-17 18:01:03]

Committed patchset #4 (id:60001) manually as
279ca87e68d80e6f858483bacb10bd7249b389d0 (presubmit successful).