Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3421)

Unified Diff: athena/content/web_contents_view_delegate_factory_impl.cc

Issue 650033004: Add NOTIMPLEMENTED for methods that should be implemented (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/content/web_activity.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/content/web_contents_view_delegate_factory_impl.cc
diff --git a/athena/content/web_contents_view_delegate_factory_impl.cc b/athena/content/web_contents_view_delegate_factory_impl.cc
index a47d0eba9ba83402841859210f36ce3966055e18..4aa304e3264b6925f6f871aa2450408e0b63f9e5 100644
--- a/athena/content/web_contents_view_delegate_factory_impl.cc
+++ b/athena/content/web_contents_view_delegate_factory_impl.cc
@@ -28,6 +28,7 @@ class WebContentsViewDelegateImpl : public content::WebContentsViewDelegate {
virtual content::WebDragDestDelegate* GetDragDestDelegate() override {
// TODO(oshima): crbug.com/401610
+ NOTIMPLEMENTED();
return NULL;
}
@@ -57,10 +58,10 @@ class WebContentsViewDelegateImpl : public content::WebContentsViewDelegate {
const gfx::NativeView content,
const base::Callback<void(ui::GestureEvent*)>& gesture_cb,
const base::Callback<void(ui::MouseEvent*)>& mouse_cb) override {
+ NOTIMPLEMENTED();
}
- virtual void HideDisambiguationPopup() override {
- }
+ virtual void HideDisambiguationPopup() override { NOTIMPLEMENTED(); }
scoped_ptr<RenderViewContextMenuImpl> BuildMenu(
content::WebContents* web_contents,
« no previous file with comments | « athena/content/web_activity.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698