athena/content/web_activity.cc - Issue 650033004: Add NOTIMPLEMENTED for methods that should be implemented

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/content/web_activity.cc

Issue 650033004: Add NOTIMPLEMENTED for methods that should be implemented (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/content/web_activity.cc

diff --git a/athena/content/web_activity.cc b/athena/content/web_activity.cc

index 6f3f31c510d33dfa6b584b99db28236c14321cf8..1850f3e594d9302672c81681a9bda302ea877a04 100644

--- a/athena/content/web_activity.cc

+++ b/athena/content/web_activity.cc

@@ -356,6 +356,12 @@ class AthenaWebView : public views::WebView {

layer->SetOpacity(0.f);

}

+ virtual content::JavaScriptDialogManager* GetJavaScriptDialogManager()

+ override {

+ NOTIMPLEMENTED();

+ return NULL;

+ }

virtual content::ColorChooser* OpenColorChooser(

content::WebContents* web_contents,

SkColor color,

« no previous file with comments | « no previous file | athena/content/web_contents_view_delegate_factory_impl.cc » ('j') | no next file with comments »