Issue 650033004: Add NOTIMPLEMENTED for methods that should be implemented

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650033004: Add NOTIMPLEMENTED for methods that should be implemented (Closed)

Created:
6 years, 2 months ago by oshima

Modified:
6 years, 2 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src@master

Project:
chromium

Visibility:
Public.

Add NOTIMPLEMENTED for methods that should be implemented BUG=None Committed: https://crrev.com/05d3a41400d281475aeeda8570be6006dd73ce6c Cr-Commit-Position: refs/heads/master@{#300006}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	athena/content/web_activity.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	athena/content/web_contents_view_delegate_factory_impl.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650033004/1

6 years, 2 months ago (2014-10-16 21:46:34 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 23:26:42 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/05d3a41400d281475aeeda8570be6006dd73ce6c
Cr-Commit-Position: refs/heads/master@{#300006}