Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 649903003: [Telemetry] Fix application_energy_consumption output. (Closed)

Created:
6 years, 2 months ago by tonyg
Modified:
6 years, 2 months ago
Reviewers:
sullivan, dtu, jeremy
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix application_energy_consumption output. Now we only try to calculate application_energy_consumption when we actually have a known quiescent power draw. This means we'll still output it on tab_switching, but not on page cycler. That should fix errors like this: http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/2187/steps/page_cycler.morejs/logs/stdio BUG= Committed: https://crrev.com/6591b536018a42c402eadf5b7dc99eab7c0b8922 Cr-Commit-Position: refs/heads/master@{#299403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/metrics/power.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tonyg
6 years, 2 months ago (2014-10-13 23:23:54 UTC) #2
dtu
lgtm
6 years, 2 months ago (2014-10-13 23:27:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649903003/1
6 years, 2 months ago (2014-10-13 23:30:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 00:25:18 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:26:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6591b536018a42c402eadf5b7dc99eab7c0b8922
Cr-Commit-Position: refs/heads/master@{#299403}

Powered by Google App Engine
This is Rietveld 408576698