tools/perf/metrics/power.py - Issue 649903003: [Telemetry] Fix application_energy_consumption output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/power.py

Issue 649903003: [Telemetry] Fix application_energy_consumption output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/power.py

diff --git a/tools/perf/metrics/power.py b/tools/perf/metrics/power.py

index a1e77ad3eb024aef42a5e3769e5e1709a3e03d22..0f33d2d41b19d751ae52f70c413578fe4e1c4798 100644

--- a/tools/perf/metrics/power.py

+++ b/tools/perf/metrics/power.py

@@ -102,7 +102,9 @@ class PowerMetric(Metric):

self._results.get('application_energy_consumption_mwh'))

total_energy_consumption_mwh = self._results.get('energy_consumption_mwh')

- if not application_energy_consumption_mwh and total_energy_consumption_mwh:

+ if (PowerMetric._quiescent_power_draw_mwh and

+ application_energy_consumption_mwh is None and

+ total_energy_consumption_mwh is not None):

application_energy_consumption_mwh = max(

total_energy_consumption_mwh - PowerMetric._quiescent_power_draw_mwh,

« no previous file with comments | « no previous file | no next file » | no next file with comments »