CQ: catch IOError thrown on socket timeouts

commit-queue/verification/try_job_on_rietveld.py

Index: commit-queue/verification/try_job_on_rietveld.py
===================================================================
--- commit-queue/verification/try_job_on_rietveld.py	(revision 233311)
+++ commit-queue/verification/try_job_on_rietveld.py	(working copy)
@@ -747,6 +747,12 @@
         return False
       else:
         raise
+    except IOError as e:
+      # Temporary AppEngine hiccup. Just log it and return failure.
+      if e.errno == 'socket error':
+        logging.warning(str(e))
+        return False
+      raise
     except socket.error as e:

[M-A Ruel, 2013/11/07 19:36:05]

I think socket.error inherits from IOError, so this code will never be executed.
Right? I'd recommend to reverse the order anyway.

[Paweł Hajdan Jr., 2013/11/07 21:02:16]

In my tests it didn't behave that way. I think sometimes python makes IOError
wrap socket.error or something similar.

Reversed the order for now. I'll test some more though.

       # Temporary AppEngine hiccup. Just log it and return failure.
       if e.errno == errno.ECONNRESET: