Close the password bubble when the fullscreen state has changed.

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
index 3b3b2b8ce191a7067df60f1b3979460b4f6972b3..9080b7133ac7aba9780905b1e8474eaebdf05185 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
@@ -6,6 +6,8 @@
 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
 
 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
 #include "ui/views/bubble/bubble_delegate.h"
 
 class ManagePasswordsIconView;
@@ -23,7 +25,8 @@ class WebContents;
 // 3. BlacklistedView: Informs the user that the current page is blacklisted.
 //
 class ManagePasswordsBubbleView : public ManagePasswordsBubble,
-                                  public views::BubbleDelegateView {
+                                  public views::BubbleDelegateView,
+                                  public content::NotificationObserver {

[Mike West, 2014/10/14 11:09:47]

It's worth asking views OWNERS whether or not registering for these kinds of
events should be higher up in the stack (e.g. in BubbleDelegateView). All
bubbles need to deal with this, right?

[msw, 2014/10/20 18:14:44]

This seems like a good signal for the browser-scoped 'popup' manager, where work
has stalled due to sufficient dev resources, etc. <http://crbug.com/375393>.

Otherwise, not all bubbles are related to web content (eg. extension popups,
global errors, avatar/profile bubble), so observing a particular web contents
doesn't necessarily make sense as a base class feature.

  public:
   // Shows the bubble.
   static void ShowBubble(content::WebContents* web_contents,
@@ -93,6 +96,11 @@ class ManagePasswordsBubbleView : public ManagePasswordsBubble,
   // views::WidgetDelegate
   virtual views::View* GetInitiallyFocusedView() override;
 
+  // content::NotificationObserver method.

[vabr (Chromium), 2014/10/14 11:26:30]

nit: There should be a single format of this type of comment, at least within a
single file. Please choose either the one used for views::WidgetDelegate or
views::BubbleDelegateView above and make all three follow the same pattern.

[vasilii, 2014/10/22 12:14:35]

Done.

+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) override;
+
   void set_initially_focused_view(views::View* view) {
     DCHECK(!initially_focused_view_);
     initially_focused_view_ = view;
@@ -116,6 +124,9 @@ class ManagePasswordsBubbleView : public ManagePasswordsBubble,
   class WebContentMouseHandler;
   scoped_ptr<WebContentMouseHandler> mouse_handler_;
 
+  // Used to register for fullscreen change notifications.
+  content::NotificationRegistrar registrar_;
+
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleView);
 };