Close the password bubble when the fullscreen state has changed.

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
 
 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
 #include "ui/views/bubble/bubble_delegate.h"
 
 class ManagePasswordsIconView;
 
 namespace content {
 class WebContents;
 }
 
 // The ManagePasswordsBubbleView controls the contents of the bubble which
 // pops up when Chrome offers to save a user's password, or when the user
 // interacts with the Omnibox icon. It has two distinct states:
 //
 // 1. PendingView: Offers the user the possibility of saving credentials.
 // 2. ManageView: Displays the current page's saved credentials.
 // 3. BlacklistedView: Informs the user that the current page is blacklisted.
 //
 class ManagePasswordsBubbleView : public ManagePasswordsBubble,
-                                  public views::BubbleDelegateView {
+                                  public views::BubbleDelegateView,
+                                  public content::NotificationObserver {

[Mike West, 2014/10/14 11:09:47]

It's worth asking views OWNERS whether or not registering for these kinds of
events should be higher up in the stack (e.g. in BubbleDelegateView). All
bubbles need to deal with this, right?

[msw, 2014/10/20 18:14:44]

This seems like a good signal for the browser-scoped 'popup' manager, where work
has stalled due to sufficient dev resources, etc. <http://crbug.com/375393>.

Otherwise, not all bubbles are related to web content (eg. extension popups,
global errors, avatar/profile bubble), so observing a particular web contents
doesn't necessarily make sense as a base class feature.

  public:
   // Shows the bubble.
   static void ShowBubble(content::WebContents* web_contents,
                          DisplayReason reason);
 
   // Closes the existing bubble.
   static void CloseBubble();
 
   // Makes the bubble the foreground window.
   static void ActivateBubble();
@@ skipping 49 matching lines @@
   // undo the action and refresh to PendingView.
   void NotifyUndoNeverForThisSite();
 
   // views::BubbleDelegateView:
   virtual void Init() override;
   virtual void WindowClosing() override;
 
   // views::WidgetDelegate
   virtual views::View* GetInitiallyFocusedView() override;
 
+  // content::NotificationObserver method.

[vabr (Chromium), 2014/10/14 11:26:30]

nit: There should be a single format of this type of comment, at least within a
single file. Please choose either the one used for views::WidgetDelegate or
views::BubbleDelegateView above and make all three follow the same pattern.

[vasilii, 2014/10/22 12:14:35]

Done.

+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) override;
+
   void set_initially_focused_view(views::View* view) {
     DCHECK(!initially_focused_view_);
     initially_focused_view_ = view;
   }
 
   // Singleton instance of the Password bubble. The Password bubble can only be
   // shown on the active browser window, so there is no case in which it will be
   // shown twice at the same time. The instance is owned by the Bubble and will
   // be deleted when the bubble closes.
   static ManagePasswordsBubbleView* manage_passwords_bubble_;
 
   ManagePasswordsIconView* anchor_view_;
 
   // If true upon destruction, the user has confirmed that she never wants to
   // save passwords for a particular site.
   bool never_save_passwords_;
 
   views::View* initially_focused_view_;
 
   // A helper to intercept mouse click events on the web contents.
   class WebContentMouseHandler;
   scoped_ptr<WebContentMouseHandler> mouse_handler_;
 
+  // Used to register for fullscreen change notifications.
+  content::NotificationRegistrar registrar_;
+
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_