Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 649633004: Add ModuleSnapshotMac (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@crashpad_info
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Patch Set 3 : Update for https://codereview.chromium.org/666483002/ #

Patch Set 4 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -24 lines) Patch
A snapshot/mac/module_snapshot_mac.h View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A snapshot/mac/module_snapshot_mac.cc View 1 2 1 chunk +152 lines, -0 lines 0 comments Download
M snapshot/mac/thread_snapshot_mac.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M snapshot/module_snapshot.h View 1 chunk +28 lines, -22 lines 0 comments Download
M snapshot/snapshot.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
This doesn’t have its own test because of bug 2. This just wraps existing well-tested ...
6 years, 2 months ago (2014-10-14 21:49:50 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/649633004/diff/1/snapshot/module_snapshot_mac.h File snapshot/module_snapshot_mac.h (right): https://codereview.chromium.org/649633004/diff/1/snapshot/module_snapshot_mac.h#newcode48 snapshot/module_snapshot_mac.h:48: //! \param[in] process_reader_thread The module within the ProcessReader ...
6 years, 2 months ago (2014-10-15 20:36:35 UTC) #3
Mark Mentovai
Updated for https://codereview.chromium.org/649633004.
6 years, 2 months ago (2014-10-17 16:26:41 UTC) #4
Mark Mentovai
6 years, 2 months ago (2014-10-17 17:56:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
6584361343aa65a2b38f491687d25ee4ef6f618f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698