Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: google_apis/gaia/account_tracker.h

Issue 649283003: Standardize usage of virtual/override/final in google_apis/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/drive/request_sender_unittest.cc ('k') | google_apis/gaia/account_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gaia/account_tracker.h
diff --git a/google_apis/gaia/account_tracker.h b/google_apis/gaia/account_tracker.h
index 2d32b7d1a46aa85e0c67b8604163808eecdd7d88..41ebd2e60dca7ab60fb501e373497b745df63251 100644
--- a/google_apis/gaia/account_tracker.h
+++ b/google_apis/gaia/account_tracker.h
@@ -45,7 +45,7 @@ class AccountTracker : public OAuth2TokenService::Observer,
public:
AccountTracker(IdentityProvider* identity_provider,
net::URLRequestContextGetter* request_context_getter);
- virtual ~AccountTracker();
+ ~AccountTracker() override;
class Observer {
public:
@@ -67,16 +67,16 @@ class AccountTracker : public OAuth2TokenService::Observer,
AccountIds FindAccountIdsByGaiaId(const std::string& gaia_id);
// OAuth2TokenService::Observer implementation.
- virtual void OnRefreshTokenAvailable(const std::string& account_key) override;
- virtual void OnRefreshTokenRevoked(const std::string& account_key) override;
+ void OnRefreshTokenAvailable(const std::string& account_key) override;
+ void OnRefreshTokenRevoked(const std::string& account_key) override;
void OnUserInfoFetchSuccess(AccountIdFetcher* fetcher,
const std::string& gaia_id);
void OnUserInfoFetchFailure(AccountIdFetcher* fetcher);
// IdentityProvider::Observer implementation.
- virtual void OnActiveAccountLogin() override;
- virtual void OnActiveAccountLogout() override;
+ void OnActiveAccountLogin() override;
+ void OnActiveAccountLogout() override;
// Sets the state of an account. Does not fire notifications.
void SetAccountStateForTest(AccountIds ids, bool is_signed_in);
@@ -120,23 +120,23 @@ class AccountIdFetcher : public OAuth2TokenService::Consumer,
net::URLRequestContextGetter* request_context_getter,
AccountTracker* tracker,
const std::string& account_key);
- virtual ~AccountIdFetcher();
+ ~AccountIdFetcher() override;
const std::string& account_key() { return account_key_; }
void Start();
// OAuth2TokenService::Consumer implementation.
- virtual void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
- const std::string& access_token,
- const base::Time& expiration_time) override;
- virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
- const GoogleServiceAuthError& error) override;
+ void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+ const std::string& access_token,
+ const base::Time& expiration_time) override;
+ void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+ const GoogleServiceAuthError& error) override;
// gaia::GaiaOAuthClient::Delegate implementation.
- virtual void OnGetUserIdResponse(const std::string& gaia_id) override;
- virtual void OnOAuthError() override;
- virtual void OnNetworkError(int response_code) override;
+ void OnGetUserIdResponse(const std::string& gaia_id) override;
+ void OnOAuthError() override;
+ void OnNetworkError(int response_code) override;
private:
OAuth2TokenService* token_service_;
« no previous file with comments | « google_apis/drive/request_sender_unittest.cc ('k') | google_apis/gaia/account_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698