Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: ui/gfx/geometry/insets.h

Issue 649203003: Type conversion fixes, ui/gfx/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/geometry/insets.h
diff --git a/ui/gfx/geometry/insets.h b/ui/gfx/geometry/insets.h
index 01379193167f042d0b9b89cb27ea721e662fd29d..6e9c70bd89c1106002e9ca8ef4e927e5679bbddb 100644
--- a/ui/gfx/geometry/insets.h
+++ b/ui/gfx/geometry/insets.h
@@ -34,7 +34,8 @@ class GFX_EXPORT Insets : public InsetsBase<Insets, int> {
}
operator InsetsF() const {
- return InsetsF(top(), left(), bottom(), right());
+ return InsetsF(static_cast<float>(top()), static_cast<float>(left()),
danakj 2014/10/18 18:40:06 i really wanna remove these int->float operators,
Peter Kasting 2014/10/20 23:38:56 I don't have an opinion, other than that I'd rathe
danakj 2014/10/23 15:35:44 Sorry ya I didn't mean in this patch, just griping
+ static_cast<float>(bottom()), static_cast<float>(right()));
}
// Returns a string representation of the insets.

Powered by Google App Engine
This is Rietveld 408576698