Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 649183006: Correctly report failure to swap RELRO pages. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/load_from_apk
Project:
chromium
Visibility:
Public.

Description

Correctly report failure to swap RELRO pages. If no RELRO pages are swapped, the library reports an error by returning false, but currently does not supply any message for the log. Add one. BUG= Committed: https://crrev.com/306811ea503c4a00f2e565ddd543134c44e3a2a1 Cr-Commit-Position: refs/heads/master@{#300120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/android_crazy_linker/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-17 16:29:28 UTC) #2
rmcilroy
On 2014/10/17 16:29:28, simonb wrote: lgtm, thanks!
6 years, 2 months ago (2014-10-17 16:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649183006/1
6 years, 2 months ago (2014-10-17 16:39:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 17:02:43 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:03:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/306811ea503c4a00f2e565ddd543134c44e3a2a1
Cr-Commit-Position: refs/heads/master@{#300120}

Powered by Google App Engine
This is Rietveld 408576698