Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp

Issue 649183006: Correctly report failure to swap RELRO pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/load_from_apk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/android_crazy_linker/README.chromium ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp
diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp b/third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp
index d8f30317b40a9e8d8c867cb6daddaa5fd760f075..8ce31e7298dfb652d6bd933b5f022d6c8417e77e 100644
--- a/third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp
+++ b/third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp
@@ -217,8 +217,10 @@ bool SharedRelro::InitFrom(size_t relro_start,
similar_size * 100 / size,
(size - similar_size) / 4096);
- if (similar_size == 0)
+ if (similar_size == 0) {
+ error->Format("No pages were swapped into RELRO ashmem\n");
return false;
+ }
start_ = relro_start;
size_ = relro_size;
« no previous file with comments | « third_party/android_crazy_linker/README.chromium ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698