Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 649073002: Removing redundant names introduced for input type checkbox with menu as parent and aria role menui… (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing redundant names introduced for input type checkbox with menu as parent and aria role menuitemcheckbox In this CL https://codereview.chromium.org/589383004/, a redundant name was introduced for input type checkbox with menu as parent. Rather the role defined for aria role menuitemcheckbox can be used for input type checkbox with menu as parent. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
According to the discussion in this CL https://codereview.chromium.org/629003003/ to introduce a single name, I have ...
6 years, 2 months ago (2014-10-12 11:40:39 UTC) #2
Mike West
Code change LGTM. Please wait for Dominic to sign off on the name.
6 years, 2 months ago (2014-10-12 11:44:16 UTC) #3
dmazzoni
lgtm
6 years, 2 months ago (2014-10-13 07:50:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649073002/1
6 years, 2 months ago (2014-10-13 07:50:15 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 08:34:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183591

Powered by Google App Engine
This is Rietveld 408576698