Source/core/accessibility/AXNodeObject.cpp - Issue 649073002: Removing redundant names introduced for input type checkbox with menu as parent and aria role menui…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 649073002: Removing redundant names introduced for input type checkbox with menu as parent and aria role menui… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/accessibility/AXNodeObject.cpp

diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp

index 383cf33a981b70241fca1184d67fb5730a44b990..1a7d5603e13e9c999460a88c343acdb7ea8da4d1 100644

--- a/Source/core/accessibility/AXNodeObject.cpp

+++ b/Source/core/accessibility/AXNodeObject.cpp

@@ -210,7 +210,7 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()

}

if (type == InputTypeNames::checkbox) {

if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))

- return CheckBoxMenuItemRole;

+ return MenuItemCheckBoxRole;

return CheckBoxRole;

}

if (type == InputTypeNames::date)

« no previous file with comments | « no previous file | Source/core/accessibility/AXObject.h » ('j') | no next file with comments »