Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 648933003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, agl, Jana, alyssar, Ian Swett, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Add more information to LOG(DFATAL) in QUIC's tcp_loss_algorithm. Merge internal change: 77370712 https://codereview.chromium.org/644123003/ Fix a bug where packet received times aren't sent if the approximate now time is less than the packet's actual receive time. Merge internal change: 77056400 https://codereview.chromium.org/643313003/ Change the pacing sender to always pacing the initial burst, even when an RTT sample hasn't been taken. Merge internal change: 77004656 https://codereview.chromium.org/644233002/ Set the server's idle timeout to 2s longer than the negotiated value(30s by default) instead of 1s, in order to prevent failed requests. Merge internal change: 76821863 https://codereview.chromium.org/651463004/ Call SetDefaults from the QuicConfig constructor instead of requiring all callers to do so. Merge internal change: 76709273 https://codereview.chromium.org/647933002 Allow the number of undecryptable QUIC packets buffered before the CHLO/SHLO to be configured in QuicConfig. Merge internal change: 76707156 On chromium side: set max undecryptable packets to the initial congestion window size in QuicStreamFactory. https://codereview.chromium.org/647923002/ QUIC - Minor formatting changes to keep in sync with internal source. Found these changes while merging changes from chromium CLs: 605733006, 605163004 Chromium code review URL: https://codereview.chromium.org/605733006/ https://codereview.chromium.org/605163004/ Merge internal change: 76636673 https://codereview.chromium.org/651513002/ Remove QuicSentPacketManager::DebugVisitor's OnSentPacket, since it's redundant to QuicConnection::DebugVisitor's OnPacketSent. Refactored QuicConnection::DebugVisitor's OnPacketSent in order to add necessary fields for the trace... visitor. Merge internal change: 76595983 https://codereview.chromium.org/627583002/ QUIC: if client provides an STK which includes CachedNetworkParams, then store these and echo them back in future STKs if we have no newer estimate to send. Flag protected behind disabled FLAGS_quic_store_cached_network_params_from_chlo. This is the followup to adding timestamp to the SourceAddressToken proto. This allowed us to copy a previously provided CachedNetworkParams into new STKs without losing timestamp data. It also paves the way for recording BW estimate accuracy in the server: we now have the client's provided BW estimate stored per connection, so we can compare against BW that we see on the new connection (this will be in a future CL). Merge internal change: 76455340 chromium: this code doesn't impact client side code because we don't parse SourceAddressToken (we keep it as a string). For QUIC server, we are not parsing optional cached_network_params. Added a TODO to convert SourcAddressToken and CachedNetworkParams to protobuf. https://codereview.chromium.org/623003002/ R=rch@chromium.org Committed: https://crrev.com/93bce7ece7f312875a9a2fd20c25c7f769e7a7e6 Cr-Commit-Position: refs/heads/master@{#299380}

Patch Set 1 #

Patch Set 2 : set max_undecryptable_packets_ to 100 #

Patch Set 3 : Merge with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -223 lines) Patch
M net/quic/congestion_control/cubic.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 5 chunks +4 lines, -13 lines 0 comments Download
M net/quic/congestion_control/pacing_sender_test.cc View 5 chunks +61 lines, -14 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 4 chunks +46 lines, -6 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 9 chunks +43 lines, -49 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 4 chunks +40 lines, -4 lines 0 comments Download
M net/quic/crypto/source_address_token.h View 3 chunks +10 lines, -0 lines 0 comments Download
M net/quic/crypto/source_address_token.cc View 1 chunk +28 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_config.h View 3 chunks +13 lines, -3 lines 0 comments Download
M net/quic/quic_config.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_config_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 12 chunks +22 lines, -23 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M net/quic/quic_connection_test.cc View 5 chunks +44 lines, -11 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 2 chunks +9 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 4 chunks +13 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 3 chunks +1 line, -5 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_server_bin.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 4 chunks +3 lines, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-11 03:46:50 UTC) #1
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-13 17:57:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648933003/620001
6 years, 2 months ago (2014-10-13 21:23:41 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:620001)
6 years, 2 months ago (2014-10-13 22:38:57 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 22:39:26 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/93bce7ece7f312875a9a2fd20c25c7f769e7a7e6
Cr-Commit-Position: refs/heads/master@{#299380}

Powered by Google App Engine
This is Rietveld 408576698