Issue 647933002: Call SetDefaults from the QuicConfig constructor instead of requiring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 647933002: Call SetDefaults from the QuicConfig constructor instead of requiring (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)

Modified:
6 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Allow_number_of_undecryptable_packets_76707156

Project:
chromium

Visibility:
Public.

More Reviews

Description

Call SetDefaults from the QuicConfig constructor instead of requiring all callers to do so. Merge internal change: 76709273 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -52 lines)			Patch
M	net/quic/crypto/quic_crypto_client_config.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_client_session_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/quic/quic_config.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/quic_config.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_config_test.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	net/quic/quic_crypto_client_stream_test.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_crypto_server_stream_test.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	net/quic/quic_end_to_end_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_http_stream_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_server_bin.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_stream_factory.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_client.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_client_bin.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_client_session_test.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	net/tools/quic/quic_server.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_server_session_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_spdy_client_stream_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages