Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648913002: Clean up vestiges of ScrollView. (Closed)

Created:
6 years, 2 months ago by skobes
Modified:
6 years, 2 months ago
CC:
aboxhall, arv+blink, blink-reviews, blink-reviews-rendering, Inactive, dglazkov+blink, dmazzoni, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mkwst+moarreviews_chromium.org, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Clean up vestiges of ScrollView. BUG=417774 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183576

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -190 lines) Patch
M LayoutTests/compositing/rubberbanding/transform-overhang-e.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-n.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-ne.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-nw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-s.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-se.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-size-change.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-sw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-w.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/panScroll-panIcon.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/resources/panScroll.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/overflow/overflow-y-scroll.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/overflow/overflow-y-scroll-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/custom-scrollbars-ne.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/custom-scrollbars-nw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/custom-scrollbars-se.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/custom-scrollbars-sw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-e.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-n.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-ne.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-nw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-s.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-se.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-sw.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/rubberbanding/overhang-w.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXScrollView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.h View 10 chunks +20 lines, -24 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 6 chunks +44 lines, -69 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Widget.h View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/platform/exported/WebScrollbarImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebScrollbarImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebScrollbarThemeClientImpl.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 1 8 chunks +15 lines, -15 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/scroll/Scrollbar.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PopupListBox.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/ViewportAnchor.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebPluginScrollbarImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebPluginScrollbarImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/WebScrollbar.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (12 generated)
skobes
(+abarth for OWNERS)
6 years, 2 months ago (2014-10-11 01:21:00 UTC) #2
abarth-chromium
Would you be willing to find another owner? I'm not reviewing many patches in Blink ...
6 years, 2 months ago (2014-10-11 02:34:30 UTC) #4
dglazkov
lgtm
6 years, 2 months ago (2014-10-11 02:59:41 UTC) #6
Ian Vollick
The refactor lgtm. \o/ https://codereview.chromium.org/648913002/diff/1/Source/core/accessibility/AXRenderObject.cpp File Source/core/accessibility/AXRenderObject.cpp (right): https://codereview.chromium.org/648913002/diff/1/Source/core/accessibility/AXRenderObject.cpp#newcode242 Source/core/accessibility/AXRenderObject.cpp:242: // If the parent is ...
6 years, 2 months ago (2014-10-11 03:05:32 UTC) #7
skobes
Thanks! https://codereview.chromium.org/648913002/diff/1/Source/core/accessibility/AXRenderObject.cpp File Source/core/accessibility/AXRenderObject.cpp (right): https://codereview.chromium.org/648913002/diff/1/Source/core/accessibility/AXRenderObject.cpp#newcode242 Source/core/accessibility/AXRenderObject.cpp:242: // If the parent is a scroll view, ...
6 years, 2 months ago (2014-10-11 04:05:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648913002/570001
6 years, 2 months ago (2014-10-11 04:06:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31294)
6 years, 2 months ago (2014-10-11 07:08:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648913002/570001
6 years, 2 months ago (2014-10-11 07:10:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31311)
6 years, 2 months ago (2014-10-11 10:21:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648913002/570001
6 years, 2 months ago (2014-10-11 11:02:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31323)
6 years, 2 months ago (2014-10-11 14:09:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648913002/570001
6 years, 2 months ago (2014-10-11 15:59:47 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648913002/570001
6 years, 2 months ago (2014-10-11 18:21:48 UTC) #25
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 19:05:59 UTC) #26
Message was sent while issue was closed. 
Committed patchset #2 (id:570001) as 183576

Powered by Google App Engine
This is Rietveld 408576698