Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2120)

Unified Diff: Source/web/PopupListBox.cpp

Issue 648913002: Clean up vestiges of ScrollView. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/scroll/ScrollbarThemeClient.h ('k') | Source/web/ViewportAnchor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/PopupListBox.cpp
diff --git a/Source/web/PopupListBox.cpp b/Source/web/PopupListBox.cpp
index da25eacac1a02130cf652b75f5821c715fed51ba..8244e5621d35fdba0fe59cbbc5189d029d6290e7 100644
--- a/Source/web/PopupListBox.cpp
+++ b/Source/web/PopupListBox.cpp
@@ -284,7 +284,7 @@ bool PopupListBox::handleKeyEvent(const PlatformKeyboardEvent& event)
HostWindow* PopupListBox::hostWindow() const
{
- // Our parent is the root ScrollView, so it is the one that has a
+ // Our parent is the root FrameView, so it is the one that has a
// HostWindow. FrameView::hostWindow() works similarly.
return parent() ? parent()->hostWindow() : 0;
}
@@ -866,7 +866,7 @@ IntRect PopupListBox::windowClipRect() const
void PopupListBox::invalidateScrollbarRect(Scrollbar* scrollbar, const IntRect& rect)
{
- // Add in our offset within the ScrollView.
+ // Add in our offset within the FrameView.
IntRect dirtyRect = rect;
dirtyRect.move(scrollbar->x(), scrollbar->y());
invalidateRect(dirtyRect);
@@ -888,7 +888,7 @@ IntRect PopupListBox::scrollableAreaBoundingBox() const
return windowClipRect();
}
-// FIXME: The following methods are based on code in ScrollView, with
+// FIXME: The following methods are based on code in FrameView, with
// simplifications for the constraints of PopupListBox (e.g. only vertical
// scrollbar, not horizontal). This functionality should be moved into
// ScrollableArea after http://crbug.com/417782 is fixed.
@@ -942,7 +942,7 @@ void PopupListBox::setFrameRect(const IntRect& newRect)
IntRect PopupListBox::visibleContentRect(IncludeScrollbarsInRect scrollbarInclusion) const
{
- // NOTE: Unlike ScrollView we do not need to incorporate any scaling factor,
+ // NOTE: Unlike FrameView we do not need to incorporate any scaling factor,
// and there is only one scrollbar to exclude.
IntSize size = frameRect().size();
Scrollbar* verticalBar = verticalScrollbar();
« no previous file with comments | « Source/platform/scroll/ScrollbarThemeClient.h ('k') | Source/web/ViewportAnchor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698