chrome/chrome_browser_ui.gypi - Issue 648833004: Componentize app_modal_dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 648833004: Componentize app_modal_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: owners Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index d08c6c5db6fa6ef97f1d9e96c4dd2dc275223c23..6e539dbf6beece66d426c9644cf7b2f2a2039340 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -71,15 +71,8 @@

'browser/ui/app_list/app_list_service.h',

'browser/ui/app_list/app_list_util.cc',

'browser/ui/app_list/app_list_util.h',

- 'browser/ui/app_modal_dialogs/app_modal_dialog.cc',

- 'browser/ui/app_modal_dialogs/app_modal_dialog.h',

- 'browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc',

- 'browser/ui/app_modal_dialogs/app_modal_dialog_queue.h',

- 'browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc',

- 'browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h',

'browser/ui/app_modal_dialogs/javascript_dialog_manager.cc',

'browser/ui/app_modal_dialogs/javascript_dialog_manager.h',

- 'browser/ui/app_modal_dialogs/native_app_modal_dialog.h',

'browser/ui/apps/app_info_dialog.h',

'browser/ui/apps/apps_metro_handler_win.cc',

'browser/ui/apps/apps_metro_handler_win.h',

@@ -2636,6 +2629,7 @@

'installer_util',

'../components/components.gyp:autofill_content_risk_proto',

'../components/components.gyp:translate_content_common',

+ '../components/components.gyp:app_modal_dialogs',

msw 2014/10/22 22:53:31 nit: sort this alphabetically

oshima 2014/10/23 00:44:12 Done.

'../content/app/resources/content_resources.gyp:content_resources',

'../media/media.gyp:media',

'../mojo/edk/mojo_edk.gyp:mojo_system_impl',