Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4007)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

Issue 648833004: Componentize app_modal_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: owners Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc ('K') | « chrome/browser/ui/views/javascript_app_modal_dialog_views.h ('k') | chrome/browser/unload_browsertest.cc » ('j') | chrome/chrome_browser_ui.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
diff --git a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
index adfcac34f165f4839894db7320a79b8775e17b00..7394d0dc0b36f66e78357f59b2e8f037be54635a 100644
--- a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
+++ b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
@@ -5,9 +5,10 @@
#include "chrome/browser/ui/views/javascript_app_modal_dialog_views.h"
#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "chrome/grit/generated_resources.h"
msw 2014/10/22 22:53:31 nit: I think you can remove this include.
oshima 2014/10/23 00:44:12 Done.
+#include "components/app_modal_dialogs/javascript_app_modal_dialog.h"
+#include "grit/components_strings.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/events/keycodes/keyboard_codes.h"
#include "ui/views/controls/message_box_view.h"
« chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc ('K') | « chrome/browser/ui/views/javascript_app_modal_dialog_views.h ('k') | chrome/browser/unload_browsertest.cc » ('j') | chrome/chrome_browser_ui.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698