Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2097)

Unified Diff: content/public/browser/screen_orientation_provider.cc

Issue 648733003: Implement ScreenOrientationDelegate on ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Generalize rotation locking Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/screen_orientation_provider.cc
diff --git a/content/public/browser/screen_orientation_provider.cc b/content/public/browser/screen_orientation_provider.cc
index 07c4c9323e5b3e417e97bd06d7175594a88eebe6..35a07eeffde67319a00fca785cc50b72d335372c 100644
--- a/content/public/browser/screen_orientation_provider.cc
+++ b/content/public/browser/screen_orientation_provider.cc
@@ -47,17 +47,19 @@ void ScreenOrientationProvider::LockOrientation(int request_id,
if (!rvh) {
dispatcher_->NotifyLockError(request_id,
blink::WebLockOrientationErrorCanceled);
+ return;
}
RenderViewHostDelegate* rvhd = rvh->GetDelegate();
if (!rvhd) {
dispatcher_->NotifyLockError(request_id,
blink::WebLockOrientationErrorCanceled);
+ return;
}
if (!rvhd->IsFullscreenForCurrentTab()) {
dispatcher_->NotifyLockError(request_id,
blink::WebLockOrientationErrorFullScreenRequired);
+ return;
mlamouri (slow - plz ping) 2014/10/15 15:51:27 I moved this fix in https://codereview.chromium.or
}
- return;
}
if (lock_orientation == blink::WebScreenOrientationLockNatural) {

Powered by Google App Engine
This is Rietveld 408576698