Implement ScreenOrientationDelegate on ChromeOS

content/public/browser/screen_orientation_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/screen_orientation_provider.h"
 
 #include "content/browser/renderer_host/render_view_host_delegate.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/screen_orientation_delegate.h"
 #include "content/public/browser/screen_orientation_dispatcher_host.h"
@@ skipping 29 matching lines @@
     dispatcher_->NotifyLockError(request_id,
                                  blink::WebLockOrientationErrorNotAvailable);
     return;
   }
 
   if (delegate_->FullScreenRequired(web_contents())) {
     RenderViewHost* rvh = web_contents()->GetRenderViewHost();
     if (!rvh) {
       dispatcher_->NotifyLockError(request_id,
                                    blink::WebLockOrientationErrorCanceled);
+      return;
     }
     RenderViewHostDelegate* rvhd = rvh->GetDelegate();
     if (!rvhd) {
       dispatcher_->NotifyLockError(request_id,
                                    blink::WebLockOrientationErrorCanceled);
+      return;
     }
     if (!rvhd->IsFullscreenForCurrentTab()) {
       dispatcher_->NotifyLockError(request_id,
           blink::WebLockOrientationErrorFullScreenRequired);
+      return;

[mlamouri (slow - plz ping), 2014/10/15 15:51:27]

I moved this fix in https://codereview.chromium.org/655273003/ given that you
are OOO for the rest of the week.

     }
-    return;
   }
 
   if (lock_orientation == blink::WebScreenOrientationLockNatural) {
     lock_orientation = GetNaturalLockType();
     if (lock_orientation == blink::WebScreenOrientationLockDefault) {
       // We are in a broken state, let's pretend we got canceled.
       dispatcher_->NotifyLockError(request_id,
                                    blink::WebLockOrientationErrorCanceled);
       return;
     }
@@ skipping 127 matching lines @@
     case blink::WebScreenOrientationLockDefault:
       NOTREACHED();
       return false;
   }
 
   NOTREACHED();
   return false;
 }
 
 } // namespace content