chrome/browser/web_resource/web_resource_service.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/web_resource_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc ('k') | chrome/browser/webdata/autocomplete_syncable_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_resource/web_resource_service.h

diff --git a/chrome/browser/web_resource/web_resource_service.h b/chrome/browser/web_resource/web_resource_service.h

index b5aa7ffe6be3880cfba10d32da8de6b8ec4b4b57..74cd8a04710360ca334cb5abfa4eaae2a0951600 100644

--- a/chrome/browser/web_resource/web_resource_service.h

+++ b/chrome/browser/web_resource/web_resource_service.h

@@ -46,12 +46,11 @@ class WebResourceService

void StartAfterDelay();

// JSONAsynchronousUnpackerDelegate methods.

- virtual void OnUnpackFinished(

- const base::DictionaryValue& parsed_json) override;

- virtual void OnUnpackError(const std::string& error_message) override;

+ void OnUnpackFinished(const base::DictionaryValue& parsed_json) override;

+ void OnUnpackError(const std::string& error_message) override;

protected:

- virtual ~WebResourceService();

+ ~WebResourceService() override;

// For the subclasses to process the result of a fetch.

virtual void Unpack(const base::DictionaryValue& parsed_json) = 0;

@@ -63,7 +62,7 @@ class WebResourceService

friend class base::RefCountedThreadSafe<WebResourceService>;

// net::URLFetcherDelegate implementation:

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// Schedules a fetch after |delay_ms| milliseconds.

void ScheduleFetch(int64 delay_ms);

@@ -75,7 +74,7 @@ class WebResourceService

void EndFetch();

// Implements ResourceRequestAllowedNotifier::Observer.

- virtual void OnResourceRequestsAllowed() override;

+ void OnResourceRequestsAllowed() override;

// Helper class used to tell this service if it's allowed to make network

// resource requests.