Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
diff --git a/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc b/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
index b779f2889aa529ed1c64d68d8d4e666ceda061d0..836c37829e10484156c548807a1dc6e8eb27fb6b 100644
--- a/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
+++ b/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
@@ -30,7 +30,7 @@ class TestNetworkChangeNotifier : public net::NetworkChangeNotifier {
}
private:
- virtual ConnectionType GetCurrentConnectionType() const override {
+ ConnectionType GetCurrentConnectionType() const override {
return connection_type_to_return_;
}
@@ -49,12 +49,9 @@ class TestEulaAcceptedNotifier : public EulaAcceptedNotifier {
: EulaAcceptedNotifier(NULL),
eula_accepted_(false) {
}
- virtual ~TestEulaAcceptedNotifier() {
- }
+ ~TestEulaAcceptedNotifier() override {}
- virtual bool IsEulaAccepted() override {
- return eula_accepted_;
- }
+ bool IsEulaAccepted() override { return eula_accepted_; }
void SetEulaAcceptedForTesting(bool eula_accepted) {
eula_accepted_ = eula_accepted;
@@ -89,9 +86,7 @@ class ResourceRequestAllowedNotifierTest
bool was_notified() const { return was_notified_; }
// ResourceRequestAllowedNotifier::Observer override:
- virtual void OnResourceRequestsAllowed() override {
- was_notified_ = true;
- }
+ void OnResourceRequestsAllowed() override { was_notified_ = true; }
// Network manipulation methods:
void SetWaitingForNetwork(bool waiting) {

Powered by Google App Engine
This is Rietveld 408576698