chrome/browser/web_resource/resource_request_allowed_notifier.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/resource_request_allowed_notifier.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_resource/promo_resource_service.h ('k') | chrome/browser/web_resource/resource_request_allowed_notifier_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_resource/resource_request_allowed_notifier.h

diff --git a/chrome/browser/web_resource/resource_request_allowed_notifier.h b/chrome/browser/web_resource/resource_request_allowed_notifier.h

index 0a48e3c7e3562d14efd0018cbad8dca28101387a..d37bfff363967d10c81b15326b7d482ca7740aca 100644

--- a/chrome/browser/web_resource/resource_request_allowed_notifier.h

+++ b/chrome/browser/web_resource/resource_request_allowed_notifier.h

@@ -47,7 +47,7 @@ class ResourceRequestAllowedNotifier

};

ResourceRequestAllowedNotifier();

- virtual ~ResourceRequestAllowedNotifier();

+ ~ResourceRequestAllowedNotifier() override;

// Sets |observer| as the service to be notified by this instance, and

// performs initial checks on the criteria. |observer| may not be NULL.

@@ -81,10 +81,10 @@ class ResourceRequestAllowedNotifier

virtual EulaAcceptedNotifier* CreateEulaNotifier();

// EulaAcceptedNotifier::Observer overrides:

- virtual void OnEulaAccepted() override;

+ void OnEulaAccepted() override;

// net::NetworkChangeNotifier::ConnectionTypeObserver overrides:

- virtual void OnConnectionTypeChanged(

+ void OnConnectionTypeChanged(

net::NetworkChangeNotifier::ConnectionType type) override;

// Tracks whether or not the observer/service depending on this class actually