chrome/browser/web_resource/promo_resource_service.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/promo_resource_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_resource/json_asynchronous_unpacker.cc ('k') | chrome/browser/web_resource/resource_request_allowed_notifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_resource/promo_resource_service.h

diff --git a/chrome/browser/web_resource/promo_resource_service.h b/chrome/browser/web_resource/promo_resource_service.h

index e38f4812b1b84f6c17a4ec0e940d45dacc2d5877..0efbc519520f37f437e6d7196f04192df95383bd 100644

--- a/chrome/browser/web_resource/promo_resource_service.h

+++ b/chrome/browser/web_resource/promo_resource_service.h

@@ -35,7 +35,7 @@ class PromoResourceService : public WebResourceService {

PromoResourceService();

private:

- virtual ~PromoResourceService();

+ ~PromoResourceService() override;

// Schedule a notification that a web resource is either going to become

// available or be no longer valid.

@@ -56,7 +56,7 @@ class PromoResourceService : public WebResourceService {

void PromoResourceStateChange();

// WebResourceService override to process the parsed information.

- virtual void Unpack(const base::DictionaryValue& parsed_json) override;

+ void Unpack(const base::DictionaryValue& parsed_json) override;

// Allows the creation of tasks to send a notification.

// This allows the PromoResourceService to notify the New Tab Page immediately