chrome/browser/upgrade_detector_impl.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/upgrade_detector_impl.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/upgrade_detector_impl.h

diff --git a/chrome/browser/upgrade_detector_impl.h b/chrome/browser/upgrade_detector_impl.h

index 0f90229a7bbd84bbafbc824cab83fb61d3ce4d7a..aeba643e5533be724362e642b7bb0ea2fd73ee1c 100644

--- a/chrome/browser/upgrade_detector_impl.h

+++ b/chrome/browser/upgrade_detector_impl.h

@@ -17,7 +17,7 @@ class UpgradeDetectorImpl :

public UpgradeDetector,

public chrome_variations::VariationsService::Observer {

public:

- virtual ~UpgradeDetectorImpl();

+ ~UpgradeDetectorImpl() override;

// Returns the currently installed Chrome version, which may be newer than the

// one currently running. Not supported on Android, iOS or ChromeOS. Must be

@@ -31,7 +31,7 @@ class UpgradeDetectorImpl :

UpgradeDetectorImpl();

// chrome_variations::VariationsService::Observer:

- virtual void OnExperimentChangesDetected(Severity severity) override;

+ void OnExperimentChangesDetected(Severity severity) override;

// Trigger an "on upgrade" notification based on the specified |time_passed|

// interval. Exposed as protected for testing.

« no previous file with comments | « chrome/browser/unload_browsertest.cc ('k') | chrome/browser/upgrade_detector_impl_unittest.cc » ('j') | no next file with comments »