Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: chrome/browser/upgrade_detector_impl_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/upgrade_detector_impl_unittest.cc
diff --git a/chrome/browser/upgrade_detector_impl_unittest.cc b/chrome/browser/upgrade_detector_impl_unittest.cc
index e8a1ada9ed65f5684e43cf6a73aa2a5dc450d3cf..a574bc88f9acab769e6074b8efd71452bcaa4d41 100644
--- a/chrome/browser/upgrade_detector_impl_unittest.cc
+++ b/chrome/browser/upgrade_detector_impl_unittest.cc
@@ -16,14 +16,14 @@
class TestUpgradeDetectorImpl : public UpgradeDetectorImpl {
public:
TestUpgradeDetectorImpl() : trigger_critical_update_call_count_(0) {}
- virtual ~TestUpgradeDetectorImpl() {}
+ ~TestUpgradeDetectorImpl() override {}
// Methods exposed for testing.
using UpgradeDetectorImpl::OnExperimentChangesDetected;
using UpgradeDetectorImpl::NotifyOnUpgradeWithTimePassed;
// UpgradeDetector:
- virtual void TriggerCriticalUpdate() override {
+ void TriggerCriticalUpdate() override {
trigger_critical_update_call_count_++;
}
@@ -45,8 +45,7 @@ class TestUpgradeNotificationListener : public content::NotificationObserver {
registrar_.Add(this, chrome::NOTIFICATION_UPGRADE_RECOMMENDED,
content::NotificationService::AllSources());
}
- virtual ~TestUpgradeNotificationListener() {
- }
+ ~TestUpgradeNotificationListener() override {}
const std::vector<int>& notifications_received() const {
return notifications_received_;
@@ -54,9 +53,9 @@ class TestUpgradeNotificationListener : public content::NotificationObserver {
private:
// content::NotificationObserver:
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override {
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override {
notifications_received_.push_back(type);
}
« no previous file with comments | « chrome/browser/upgrade_detector_impl.h ('k') | chrome/browser/web_resource/eula_accepted_notifier_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698