Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7258)

Unified Diff: chrome/browser/spellchecker/spelling_service_client_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spelling_service_client_unittest.cc
diff --git a/chrome/browser/spellchecker/spelling_service_client_unittest.cc b/chrome/browser/spellchecker/spelling_service_client_unittest.cc
index 59185b16deb67abc08bc8c0808e1714feefbc19b..3f2516dd63b2f4b59aa97522e0e1350db4b2664c 100644
--- a/chrome/browser/spellchecker/spelling_service_client_unittest.cc
+++ b/chrome/browser/spellchecker/spelling_service_client_unittest.cc
@@ -45,11 +45,10 @@ class TestSpellingURLFetcher : public net::TestURLFetcher {
set_response_code(status);
SetResponseString(response);
}
- virtual ~TestSpellingURLFetcher() {
- }
+ ~TestSpellingURLFetcher() override {}
- virtual void SetUploadData(const std::string& upload_content_type,
- const std::string& upload_content) override {
+ void SetUploadData(const std::string& upload_content_type,
+ const std::string& upload_content) override {
// Verify the given content type is JSON. (The Spelling service returns an
// internal server error when this content type is not JSON.)
EXPECT_EQ("application/json", upload_content_type);
@@ -79,7 +78,7 @@ class TestSpellingURLFetcher : public net::TestURLFetcher {
net::TestURLFetcher::SetUploadData(upload_content_type, upload_content);
}
- virtual void Start() override {
+ void Start() override {
// Verify that this client does not either send cookies to the Spelling
// service or accept cookies from it.
EXPECT_EQ(net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES,
@@ -122,8 +121,7 @@ class TestingSpellingServiceClient : public SpellingServiceClient {
success_(false),
fetcher_(NULL) {
}
- virtual ~TestingSpellingServiceClient() {
- }
+ ~TestingSpellingServiceClient() override {}
void SetHTTPRequest(int type,
const std::string& text,
@@ -168,7 +166,7 @@ class TestingSpellingServiceClient : public SpellingServiceClient {
}
private:
- virtual net::URLFetcher* CreateURLFetcher(const GURL& url) override {
+ net::URLFetcher* CreateURLFetcher(const GURL& url) override {
EXPECT_EQ("https://www.googleapis.com/rpc", url.spec());
fetcher_ = new TestSpellingURLFetcher(0, url, this,
request_type_, request_text_,
« no previous file with comments | « chrome/browser/spellchecker/spelling_service_client.h ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698