chrome/browser/spellchecker/spelling_service_client.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spelling_service_client.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_service.h ('k') | chrome/browser/spellchecker/spelling_service_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spelling_service_client.h

diff --git a/chrome/browser/spellchecker/spelling_service_client.h b/chrome/browser/spellchecker/spelling_service_client.h

index 4af6bf97e7390fbfb00ed429835fb2848b5ae488..4b5b4dfd967112d903b7d6dddbb5d551f7d6a8b3 100644

--- a/chrome/browser/spellchecker/spelling_service_client.h

+++ b/chrome/browser/spellchecker/spelling_service_client.h

@@ -76,7 +76,7 @@ class SpellingServiceClient : public net::URLFetcherDelegate {

TextCheckCompleteCallback;

SpellingServiceClient();

- virtual ~SpellingServiceClient();

+ ~SpellingServiceClient() override;

// Sends a text-check request to the Spelling service. When we send a request

// to the Spelling service successfully, this function returns true. (This

@@ -110,7 +110,7 @@ class SpellingServiceClient : public net::URLFetcherDelegate {

};

// net::URLFetcherDelegate implementation.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// Creates a URLFetcher object used for sending a JSON-RPC request. This

// function is overridden by unit tests to prevent them from actually sending