chrome/browser/spellchecker/spellcheck_message_filter_mac.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_mac.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_message_filter.h ('k') | chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_message_filter_mac.h

diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_mac.h b/chrome/browser/spellchecker/spellcheck_message_filter_mac.h

index 469715c516dea2c6bc75016a24581a1bb83c7ebe..18129b352d208d97bc920052024f396ab56d4732 100644

--- a/chrome/browser/spellchecker/spellcheck_message_filter_mac.h

+++ b/chrome/browser/spellchecker/spellcheck_message_filter_mac.h

@@ -18,10 +18,9 @@ class SpellCheckMessageFilterMac : public content::BrowserMessageFilter {

explicit SpellCheckMessageFilterMac(int render_process_id);

// BrowserMessageFilter implementation.

- virtual void OverrideThreadForMessage(

- const IPC::Message& message,

- content::BrowserThread::ID* thread) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OverrideThreadForMessage(const IPC::Message& message,

+ content::BrowserThread::ID* thread) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// Adjusts remote_results by examining local_results. Any result that's both

// local and remote stays type SPELLING, all others are flagged GRAMMAR.

@@ -34,7 +33,7 @@ class SpellCheckMessageFilterMac : public content::BrowserMessageFilter {

friend class TestingSpellCheckMessageFilter;

friend class SpellcheckMessageFilterMacTest;

- virtual ~SpellCheckMessageFilterMac();

+ ~SpellCheckMessageFilterMac() override;

void OnCheckSpelling(const base::string16& word, int route_id, bool* correct);

void OnFillSuggestionList(const base::string16& word,