chrome/browser/spellchecker/spellcheck_message_filter.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h ('k') | chrome/browser/spellchecker/spellcheck_message_filter_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_message_filter.h

diff --git a/chrome/browser/spellchecker/spellcheck_message_filter.h b/chrome/browser/spellchecker/spellcheck_message_filter.h

index 0eebe1340bf7d00082360c55f67b7f50e952a377..dbc8f9cc5d4fa412fbfaafedd9d52a7b2e8da0d1 100644

--- a/chrome/browser/spellchecker/spellcheck_message_filter.h

+++ b/chrome/browser/spellchecker/spellcheck_message_filter.h

@@ -21,15 +21,14 @@ class SpellCheckMessageFilter : public content::BrowserMessageFilter {

explicit SpellCheckMessageFilter(int render_process_id);

// content::BrowserMessageFilter implementation.

- virtual void OverrideThreadForMessage(

- const IPC::Message& message,

- content::BrowserThread::ID* thread) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OverrideThreadForMessage(const IPC::Message& message,

+ content::BrowserThread::ID* thread) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

private:

friend class TestingSpellCheckMessageFilter;

- virtual ~SpellCheckMessageFilter();

+ ~SpellCheckMessageFilter() override;

void OnSpellCheckerRequestDictionary();

void OnNotifyChecked(const base::string16& word, bool misspelled);