chrome/browser/services/gcm/gcm_profile_service.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/services/gcm/gcm_account_tracker_unittest.cc ('k') | chrome/browser/services/gcm/gcm_profile_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/gcm_profile_service.h

diff --git a/chrome/browser/services/gcm/gcm_profile_service.h b/chrome/browser/services/gcm/gcm_profile_service.h

index 52ef650a7c29b0fca30ba20dd03af2add018bf35..ef3254eb0e02de8ed13816546efc76d70e34583b 100644

--- a/chrome/browser/services/gcm/gcm_profile_service.h

+++ b/chrome/browser/services/gcm/gcm_profile_service.h

@@ -42,7 +42,7 @@ class GCMProfileService : public KeyedService {

GCMProfileService(Profile* profile,

scoped_ptr<GCMClientFactory> gcm_client_factory);

#endif

- virtual ~GCMProfileService();

+ ~GCMProfileService() override;

// TODO(jianli): obsolete methods that are going to be removed soon.

void AddAppHandler(const std::string& app_id, GCMAppHandler* handler);

@@ -52,7 +52,7 @@ class GCMProfileService : public KeyedService {

const GCMDriver::RegisterCallback& callback);

// KeyedService:

- virtual void Shutdown() override;

+ void Shutdown() override;

// Returns the user name if the profile is signed in or an empty string

// otherwise.

« no previous file with comments | « chrome/browser/services/gcm/gcm_account_tracker_unittest.cc ('k') | chrome/browser/services/gcm/gcm_profile_service.cc » ('j') | no next file with comments »