chrome/browser/services/gcm/gcm_profile_service.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/services/gcm/gcm_profile_service.h ('k') | chrome/browser/services/gcm/gcm_profile_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/gcm_profile_service.cc

diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc

index 8cf374b299a4662d4efce113681c4df755e418a5..c13a3db9a3197e89c51c1471af29ada0c50477d8 100644

--- a/chrome/browser/services/gcm/gcm_profile_service.cc

+++ b/chrome/browser/services/gcm/gcm_profile_service.cc

@@ -44,11 +44,11 @@ namespace gcm {

class GCMProfileService::IdentityObserver : public IdentityProvider::Observer {

public:

IdentityObserver(Profile* profile, GCMDriver* driver);

- virtual ~IdentityObserver();

+ ~IdentityObserver() override;

// IdentityProvider::Observer:

- virtual void OnActiveAccountLogin() override;

- virtual void OnActiveAccountLogout() override;

+ void OnActiveAccountLogin() override;

+ void OnActiveAccountLogout() override;

std::string SignedInUserName() const;

« no previous file with comments | « chrome/browser/services/gcm/gcm_profile_service.h ('k') | chrome/browser/services/gcm/gcm_profile_service_factory.h » ('j') | no next file with comments »