chrome/browser/service_process/service_process_control.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/service_process/service_process_control.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search_engines/ui_thread_search_terms_data.h ('k') | chrome/browser/service_process/service_process_control_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/service_process/service_process_control.h

diff --git a/chrome/browser/service_process/service_process_control.h b/chrome/browser/service_process/service_process_control.h

index 35ab57af6904027623c04540a257133b9946f19d..8a1074b4e9380e96b67c63fd58a656b22b073fbf 100644

--- a/chrome/browser/service_process/service_process_control.h

+++ b/chrome/browser/service_process/service_process_control.h

@@ -98,17 +98,17 @@ class ServiceProcessControl : public IPC::Sender,

virtual void Disconnect();

// IPC::Listener implementation.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OnChannelConnected(int32 peer_pid) override;

- virtual void OnChannelError() override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void OnChannelConnected(int32 peer_pid) override;

+ void OnChannelError() override;

// IPC::Sender implementation

- virtual bool Send(IPC::Message* message) override;

+ bool Send(IPC::Message* message) override;

// content::NotificationObserver implementation.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// Send a shutdown message to the service process. IPC channel will be

// destroyed after calling this method.

@@ -177,7 +177,7 @@ class ServiceProcessControl : public IPC::Sender,

friend class CloudPrintProxyPolicyStartupTest;

ServiceProcessControl();

- virtual ~ServiceProcessControl();

+ ~ServiceProcessControl() override;

friend struct DefaultSingletonTraits<ServiceProcessControl>;