chrome/browser/search_engines/ui_thread_search_terms_data.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/ui_thread_search_terms_data.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search_engines/template_url_service_test_util.cc ('k') | chrome/browser/service_process/service_process_control.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/ui_thread_search_terms_data.h

diff --git a/chrome/browser/search_engines/ui_thread_search_terms_data.h b/chrome/browser/search_engines/ui_thread_search_terms_data.h

index 811c60f94b76243974c2357f1eb5028432006d80..616bdd0e991e86b2a20fa3535ad9a9e5817834e5 100644

--- a/chrome/browser/search_engines/ui_thread_search_terms_data.h

+++ b/chrome/browser/search_engines/ui_thread_search_terms_data.h

@@ -21,22 +21,19 @@ class UIThreadSearchTermsData : public SearchTermsData {

// values, and NTPIsThemedParam() will return an empty string.

explicit UIThreadSearchTermsData(Profile* profile);

- virtual std::string GoogleBaseURLValue() const override;

- virtual std::string GetApplicationLocale() const override;

- virtual base::string16 GetRlzParameterValue(bool from_app_list) const

- override;

- virtual std::string GetSearchClient() const override;

- virtual std::string GetSuggestClient() const override;

- virtual std::string GetSuggestRequestIdentifier() const override;

- virtual bool EnableAnswersInSuggest() const override;

- virtual bool IsShowingSearchTermsOnSearchResultsPages() const override;

- virtual std::string InstantExtendedEnabledParam(

- bool for_search) const override;

- virtual std::string ForceInstantResultsParam(

- bool for_prerender) const override;

- virtual int OmniboxStartMargin() const override;

- virtual std::string NTPIsThemedParam() const override;

- virtual std::string GoogleImageSearchSource() const override;

+ std::string GoogleBaseURLValue() const override;

+ std::string GetApplicationLocale() const override;

+ base::string16 GetRlzParameterValue(bool from_app_list) const override;

+ std::string GetSearchClient() const override;

+ std::string GetSuggestClient() const override;

+ std::string GetSuggestRequestIdentifier() const override;

+ bool EnableAnswersInSuggest() const override;

+ bool IsShowingSearchTermsOnSearchResultsPages() const override;

+ std::string InstantExtendedEnabledParam(bool for_search) const override;

+ std::string ForceInstantResultsParam(bool for_prerender) const override;

+ int OmniboxStartMargin() const override;

+ std::string NTPIsThemedParam() const override;

+ std::string GoogleImageSearchSource() const override;

// Used by tests to override the value for the Google base URL. Passing the

// empty string cancels this override.