Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5724)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
index 915e24cef03daf7e867add06d65123098e89e313..fc41b85d714e595e6a872100e06111c1bd18c651 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h
@@ -35,21 +35,20 @@ class ChromeResourceDispatcherHostDelegate
// |prerender_tracker| must outlive |this|.
explicit ChromeResourceDispatcherHostDelegate(
prerender::PrerenderTracker* prerender_tracker);
- virtual ~ChromeResourceDispatcherHostDelegate();
+ ~ChromeResourceDispatcherHostDelegate() override;
// ResourceDispatcherHostDelegate implementation.
- virtual bool ShouldBeginRequest(
- const std::string& method,
- const GURL& url,
- content::ResourceType resource_type,
- content::ResourceContext* resource_context) override;
- virtual void RequestBeginning(
+ bool ShouldBeginRequest(const std::string& method,
+ const GURL& url,
+ content::ResourceType resource_type,
+ content::ResourceContext* resource_context) override;
+ void RequestBeginning(
net::URLRequest* request,
content::ResourceContext* resource_context,
content::AppCacheService* appcache_service,
content::ResourceType resource_type,
ScopedVector<content::ResourceThrottle>* throttles) override;
- virtual void DownloadStarting(
+ void DownloadStarting(
net::URLRequest* request,
content::ResourceContext* resource_context,
int child_id,
@@ -58,32 +57,29 @@ class ChromeResourceDispatcherHostDelegate
bool is_content_initiated,
bool must_download,
ScopedVector<content::ResourceThrottle>* throttles) override;
- virtual content::ResourceDispatcherHostLoginDelegate* CreateLoginDelegate(
- net::AuthChallengeInfo* auth_info, net::URLRequest* request) override;
- virtual bool HandleExternalProtocol(const GURL& url,
- int child_id,
- int route_id) override;
- virtual bool ShouldForceDownloadResource(
- const GURL& url, const std::string& mime_type) override;
- virtual bool ShouldInterceptResourceAsStream(
- net::URLRequest* request,
- const std::string& mime_type,
- GURL* origin,
- std::string* payload) override;
- virtual void OnStreamCreated(
- net::URLRequest* request,
- scoped_ptr<content::StreamInfo> stream) override;
- virtual void OnResponseStarted(
- net::URLRequest* request,
- content::ResourceContext* resource_context,
- content::ResourceResponse* response,
- IPC::Sender* sender) override;
- virtual void OnRequestRedirected(
- const GURL& redirect_url,
- net::URLRequest* request,
- content::ResourceContext* resource_context,
- content::ResourceResponse* response) override;
- virtual void RequestComplete(net::URLRequest* url_request) override;
+ content::ResourceDispatcherHostLoginDelegate* CreateLoginDelegate(
+ net::AuthChallengeInfo* auth_info,
+ net::URLRequest* request) override;
+ bool HandleExternalProtocol(const GURL& url,
+ int child_id,
+ int route_id) override;
+ bool ShouldForceDownloadResource(const GURL& url,
+ const std::string& mime_type) override;
+ bool ShouldInterceptResourceAsStream(net::URLRequest* request,
+ const std::string& mime_type,
+ GURL* origin,
+ std::string* payload) override;
+ void OnStreamCreated(net::URLRequest* request,
+ scoped_ptr<content::StreamInfo> stream) override;
+ void OnResponseStarted(net::URLRequest* request,
+ content::ResourceContext* resource_context,
+ content::ResourceResponse* response,
+ IPC::Sender* sender) override;
+ void OnRequestRedirected(const GURL& redirect_url,
+ net::URLRequest* request,
+ content::ResourceContext* resource_context,
+ content::ResourceResponse* response) override;
+ void RequestComplete(net::URLRequest* url_request) override;
// Called on the UI thread. Allows switching out the
// ExternalProtocolHandler::Delegate for testing code.

Powered by Google App Engine
This is Rietveld 408576698