chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

index 6c571a32287d94f971b9d18feb41d90883a545a7..65317061c38028990e3af713358af437c5d3a8fe 100644

--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm

@@ -82,7 +82,7 @@ class ChromeRenderWidgetHostViewMacHistorySwiperTest

base_path, base::FilePath(FILE_PATH_LITERAL("iframe.html")));

}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

event_queue_.reset([[NSMutableArray alloc] init]);

touch_ = CGPointMake(0.5, 0.5);

@@ -93,9 +93,7 @@ class ChromeRenderWidgetHostViewMacHistorySwiperTest

ASSERT_EQ(url2_, GetWebContents()->GetURL());

}

- virtual void TearDownOnMainThread() override {

- event_queue_.reset();

- }

+ void TearDownOnMainThread() override { event_queue_.reset(); }

protected:

// Returns the active web contents.