chrome/browser/renderer_context_menu/spelling_menu_observer.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spelling_menu_observer.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_bubble_model.h ('k') | chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spelling_menu_observer.h

diff --git a/chrome/browser/renderer_context_menu/spelling_menu_observer.h b/chrome/browser/renderer_context_menu/spelling_menu_observer.h

index c6db4f3c63c488f2cb834398213a5b41783e2c1f..a29965de2f727d95129101daa737c520e87fadaf 100644

--- a/chrome/browser/renderer_context_menu/spelling_menu_observer.h

+++ b/chrome/browser/renderer_context_menu/spelling_menu_observer.h

@@ -40,15 +40,15 @@ struct SpellCheckResult;

class SpellingMenuObserver : public RenderViewContextMenuObserver {

public:

explicit SpellingMenuObserver(RenderViewContextMenuProxy* proxy);

- virtual ~SpellingMenuObserver();

+ ~SpellingMenuObserver() override;

// RenderViewContextMenuObserver implementation.

- virtual void InitMenu(const content::ContextMenuParams& params) override;

- virtual bool IsCommandIdSupported(int command_id) override;

- virtual bool IsCommandIdChecked(int command_id) override;

- virtual bool IsCommandIdEnabled(int command_id) override;

- virtual void ExecuteCommand(int command_id) override;

- virtual void OnMenuCancel() override;

+ void InitMenu(const content::ContextMenuParams& params) override;

+ bool IsCommandIdSupported(int command_id) override;

+ bool IsCommandIdChecked(int command_id) override;

+ bool IsCommandIdEnabled(int command_id) override;

+ void ExecuteCommand(int command_id) override;

+ void OnMenuCancel() override;

// A callback function called when the Spelling service finishes checking a

// misspelled word.