chrome/browser/renderer_context_menu/spelling_bubble_model.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spelling_bubble_model.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc ('k') | chrome/browser/renderer_context_menu/spelling_menu_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spelling_bubble_model.h

diff --git a/chrome/browser/renderer_context_menu/spelling_bubble_model.h b/chrome/browser/renderer_context_menu/spelling_bubble_model.h

index 4c19a2c0a5feec6635ee583369f68aecdaa424dc..265f90b9aad99887b8f4128bdcb0b23279eaf110 100644

--- a/chrome/browser/renderer_context_menu/spelling_bubble_model.h

+++ b/chrome/browser/renderer_context_menu/spelling_bubble_model.h

@@ -22,17 +22,17 @@ class SpellingBubbleModel : public ConfirmBubbleModel {

SpellingBubbleModel(Profile* profile,

content::WebContents* web_contents,

bool include_autocorrect);

- virtual ~SpellingBubbleModel();

+ ~SpellingBubbleModel() override;

// ConfirmBubbleModel implementation.

- virtual base::string16 GetTitle() const override;

- virtual base::string16 GetMessageText() const override;

- virtual gfx::Image* GetIcon() const override;

- virtual base::string16 GetButtonLabel(BubbleButton button) const override;

- virtual void Accept() override;

- virtual void Cancel() override;

- virtual base::string16 GetLinkText() const override;

- virtual void LinkClicked() override;

+ base::string16 GetTitle() const override;

+ base::string16 GetMessageText() const override;

+ gfx::Image* GetIcon() const override;

+ base::string16 GetButtonLabel(BubbleButton button) const override;

+ void Accept() override;

+ void Cancel() override;

+ base::string16 GetLinkText() const override;

+ void LinkClicked() override;

private:

// Set the profile preferences to enable or disable the feature.