chrome/browser/predictors/resource_prefetch_predictor_tables.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_tables.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h ('k') | chrome/browser/predictors/resource_prefetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/resource_prefetch_predictor_tables.h

diff --git a/chrome/browser/predictors/resource_prefetch_predictor_tables.h b/chrome/browser/predictors/resource_prefetch_predictor_tables.h

index d4554535797a09c09e41313f714f294f44472196..84f0eba6c78214a4c88af7c5994bb1b1b80053d1 100644

--- a/chrome/browser/predictors/resource_prefetch_predictor_tables.h

+++ b/chrome/browser/predictors/resource_prefetch_predictor_tables.h

@@ -121,7 +121,7 @@ class ResourcePrefetchPredictorTables : public PredictorTableBase {

friend class MockResourcePrefetchPredictorTables;

ResourcePrefetchPredictorTables();

- virtual ~ResourcePrefetchPredictorTables();

+ ~ResourcePrefetchPredictorTables() override;

// Helper functions below help perform functions on the Url and host table

// using the same code.

@@ -137,8 +137,8 @@ class ResourcePrefetchPredictorTables : public PredictorTableBase {

bool StringsAreSmallerThanDBLimit(const PrefetchData& data) const;

// PredictorTableBase methods.

- virtual void CreateTableIfNonExistent() override;

- virtual void LogDatabaseStats() override;

+ void CreateTableIfNonExistent() override;

+ void LogDatabaseStats() override;

// Helpers to return Statements for cached Statements. The caller must take

// ownership of the return Statements.