chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/resource_prefetch_predictor_factory.h ('k') | chrome/browser/predictors/resource_prefetch_predictor_tables.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h

diff --git a/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h b/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h

index e70c3454e679e893292ebc70f74d024e1b39a8de..e1d57e85442974349c70d7cbf0cf9b9115a4675c 100644

--- a/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h

+++ b/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.h

@@ -14,11 +14,11 @@ class ResourcePrefetchPredictorTabHelper

: public content::WebContentsObserver,

public content::WebContentsUserData<ResourcePrefetchPredictorTabHelper> {

public:

- virtual ~ResourcePrefetchPredictorTabHelper();

+ ~ResourcePrefetchPredictorTabHelper() override;

// content::WebContentsObserver implementation

- virtual void DocumentOnLoadCompletedInMainFrame() override;

- virtual void DidLoadResourceFromMemoryCache(

+ void DocumentOnLoadCompletedInMainFrame() override;

+ void DidLoadResourceFromMemoryCache(

const content::LoadFromMemoryCacheDetails& details) override;

private: