Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2024)

Unified Diff: chrome/browser/metrics/variations/variations_service_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service_unittest.cc
diff --git a/chrome/browser/metrics/variations/variations_service_unittest.cc b/chrome/browser/metrics/variations/variations_service_unittest.cc
index bf79eff5c07b7935f99aabb6430c68b37c1de96c..4c190a3ce0c7b0c6d6746e4e198609ddbdf92ebc 100644
--- a/chrome/browser/metrics/variations/variations_service_unittest.cc
+++ b/chrome/browser/metrics/variations/variations_service_unittest.cc
@@ -47,8 +47,7 @@ class TestVariationsService : public VariationsService {
SetCreateTrialsFromSeedCalledForTesting(true);
}
- virtual ~TestVariationsService() {
- }
+ ~TestVariationsService() override {}
void set_intercepts_fetch(bool value) {
intercepts_fetch_ = value;
@@ -58,7 +57,7 @@ class TestVariationsService : public VariationsService {
bool seed_stored() const { return seed_stored_; }
- virtual void DoActualFetch() override {
+ void DoActualFetch() override {
if (intercepts_fetch_) {
fetch_attempted_ = true;
return;
@@ -68,9 +67,9 @@ class TestVariationsService : public VariationsService {
}
protected:
- virtual void StoreSeed(const std::string& seed_data,
- const std::string& seed_signature,
- const base::Time& date_fetched) override {
+ void StoreSeed(const std::string& seed_data,
+ const std::string& seed_signature,
+ const base::Time& date_fetched) override {
seed_stored_ = true;
}
@@ -88,10 +87,9 @@ class TestVariationsServiceObserver : public VariationsService::Observer {
: best_effort_changes_notified_(0),
crticial_changes_notified_(0) {
}
- virtual ~TestVariationsServiceObserver() {
- }
+ ~TestVariationsServiceObserver() override {}
- virtual void OnExperimentChangesDetected(Severity severity) override {
+ void OnExperimentChangesDetected(Severity severity) override {
switch (severity) {
case BEST_EFFORT:
++best_effort_changes_notified_;
« no previous file with comments | « chrome/browser/metrics/variations/variations_service.h ('k') | chrome/browser/nacl_host/nacl_browser_delegate_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698