chrome/browser/metrics/variations/variations_service.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/variations/variations_seed_store_unittest.cc ('k') | chrome/browser/metrics/variations/variations_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/variations_service.h

diff --git a/chrome/browser/metrics/variations/variations_service.h b/chrome/browser/metrics/variations/variations_service.h

index effec59f1f3ff5f00ce87c7b944ce0ed0f869cb1..afcfc6ea7d4ea9c5acc42f4fa95d8393d8b76b23 100644

--- a/chrome/browser/metrics/variations/variations_service.h

+++ b/chrome/browser/metrics/variations/variations_service.h

@@ -72,7 +72,7 @@ class VariationsService

virtual ~Observer() {}

};

- virtual ~VariationsService();

+ ~VariationsService() override;

// Creates field trials based on Variations Seed loaded from local prefs. If

// there is a problem loading the seed data, all trials specified by the seed

@@ -173,10 +173,10 @@ class VariationsService

const variations::VariationsSeedSimulator::Result& result);

// net::URLFetcherDelegate implementation:

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// ResourceRequestAllowedNotifier::Observer implementation:

- virtual void OnResourceRequestsAllowed() override;

+ void OnResourceRequestsAllowed() override;

// Performs a variations seed simulation with the given |seed| and |version|

// and logs the simulation results as histograms.