Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/metrics/signin_status_metrics_provider.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/plugin_metrics_provider.h ('k') | chrome/browser/metrics/thread_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/signin_status_metrics_provider.h
diff --git a/chrome/browser/metrics/signin_status_metrics_provider.h b/chrome/browser/metrics/signin_status_metrics_provider.h
index 442b45dff291675d47c47b426d07a08fb019072e..5c0fb557c6dee31b827f5fc17d9e18944e72d23c 100644
--- a/chrome/browser/metrics/signin_status_metrics_provider.h
+++ b/chrome/browser/metrics/signin_status_metrics_provider.h
@@ -34,7 +34,7 @@ class SigninStatusMetricsProvider : public metrics::MetricsProvider,
public SigninManagerBase::Observer,
public SigninManagerFactory::Observer {
public:
- virtual ~SigninStatusMetricsProvider();
+ ~SigninStatusMetricsProvider() override;
// metrics::MetricsProvider:
void ProvideGeneralMetrics(
@@ -71,18 +71,18 @@ class SigninStatusMetricsProvider : public metrics::MetricsProvider,
// chrome::BrowserListObserver:
// This will never be called on Android.
- virtual void OnBrowserAdded(Browser* browser) override;
+ void OnBrowserAdded(Browser* browser) override;
// SigninManagerFactory::Observer:
- virtual void SigninManagerCreated(SigninManagerBase* manager) override;
- virtual void SigninManagerShutdown(SigninManagerBase* manager) override;
+ void SigninManagerCreated(SigninManagerBase* manager) override;
+ void SigninManagerShutdown(SigninManagerBase* manager) override;
// SigninManagerBase::Observer:
- virtual void GoogleSigninSucceeded(const std::string& account_id,
- const std::string& username,
- const std::string& password) override;
- virtual void GoogleSignedOut(const std::string& account_id,
- const std::string& username) override;
+ void GoogleSigninSucceeded(const std::string& account_id,
+ const std::string& username,
+ const std::string& password) override;
+ void GoogleSignedOut(const std::string& account_id,
+ const std::string& username) override;
// Obtain sign-in status and add observers.
void Initialize();
« no previous file with comments | « chrome/browser/metrics/plugin_metrics_provider.h ('k') | chrome/browser/metrics/thread_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698