Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6297)

Unified Diff: chrome/browser/metrics/plugin_metrics_provider.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/plugin_metrics_provider.h
diff --git a/chrome/browser/metrics/plugin_metrics_provider.h b/chrome/browser/metrics/plugin_metrics_provider.h
index acefeb1fa0bc34e3c5c1cb5a43ce8287879c4280..8d374c98a681ee470ba5801b04bbcaef57935942 100644
--- a/chrome/browser/metrics/plugin_metrics_provider.h
+++ b/chrome/browser/metrics/plugin_metrics_provider.h
@@ -32,18 +32,18 @@ class PluginMetricsProvider : public metrics::MetricsProvider,
public content::BrowserChildProcessObserver {
public:
explicit PluginMetricsProvider(PrefService* local_state);
- virtual ~PluginMetricsProvider();
+ ~PluginMetricsProvider() override;
// Fetches plugin information data asynchronously and calls |done_callback|
// when done.
void GetPluginInformation(const base::Closure& done_callback);
// metrics::MetricsDataProvider:
- virtual void ProvideSystemProfileMetrics(
+ void ProvideSystemProfileMetrics(
metrics::SystemProfileProto* system_profile_proto) override;
- virtual void ProvideStabilityMetrics(
+ void ProvideStabilityMetrics(
metrics::SystemProfileProto* system_profile_proto) override;
- virtual void ClearSavedStabilityMetrics() override;
+ void ClearSavedStabilityMetrics() override;
// Notifies the provider about an error loading the plugin at |plugin_path|.
void LogPluginLoadingError(const base::FilePath& plugin_path);
@@ -88,11 +88,11 @@ class PluginMetricsProvider : public metrics::MetricsProvider,
bool RecordCurrentStateIfPending();
// content::BrowserChildProcessObserver:
- virtual void BrowserChildProcessHostConnected(
+ void BrowserChildProcessHostConnected(
const content::ChildProcessData& data) override;
- virtual void BrowserChildProcessCrashed(
+ void BrowserChildProcessCrashed(
const content::ChildProcessData& data) override;
- virtual void BrowserChildProcessInstanceCreated(
+ void BrowserChildProcessInstanceCreated(
const content::ChildProcessData& data) override;
PrefService* local_state_;
« no previous file with comments | « chrome/browser/metrics/omnibox_metrics_provider.h ('k') | chrome/browser/metrics/signin_status_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698