Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
index 6d00b365380a9c53f4d9958249980eda6bc97bb8..ae6e00bd09dd69d986468c18bcbfe680eeba6d5e 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
@@ -17,46 +17,42 @@ class ChromeWebViewPermissionHelperDelegate :
public:
explicit ChromeWebViewPermissionHelperDelegate(
extensions::WebViewPermissionHelper* web_view_permission_helper);
- virtual ~ChromeWebViewPermissionHelperDelegate();
+ ~ChromeWebViewPermissionHelperDelegate() override;
// WebViewPermissionHelperDelegate implementation.
- virtual void CanDownload(
- content::RenderViewHost* render_view_host,
- const GURL& url,
- const std::string& request_method,
- const base::Callback<void(bool)>& callback) override;
- virtual void RequestPointerLockPermission(
+ void CanDownload(content::RenderViewHost* render_view_host,
+ const GURL& url,
+ const std::string& request_method,
+ const base::Callback<void(bool)>& callback) override;
+ void RequestPointerLockPermission(
bool user_gesture,
bool last_unlocked_by_target,
const base::Callback<void(bool)>& callback) override;
- virtual void RequestGeolocationPermission(
+ void RequestGeolocationPermission(
int bridge_id,
const GURL& requesting_frame,
bool user_gesture,
const base::Callback<void(bool)>& callback) override;
- virtual void CancelGeolocationPermissionRequest(int bridge_id) override;
- virtual void RequestFileSystemPermission(
+ void CancelGeolocationPermissionRequest(int bridge_id) override;
+ void RequestFileSystemPermission(
const GURL& url,
bool allowed_by_default,
const base::Callback<void(bool)>& callback) override;
- virtual void FileSystemAccessedAsync(
- int render_process_id,
- int render_frame_id,
- int request_id,
- const GURL& url,
- bool blocked_by_policy) override;
- virtual void FileSystemAccessedSync(
- int render_process_id,
- int render_frame_id,
- const GURL& url,
- bool blocked_by_policy,
- IPC::Message* reply_msg) override;
+ void FileSystemAccessedAsync(int render_process_id,
+ int render_frame_id,
+ int request_id,
+ const GURL& url,
+ bool blocked_by_policy) override;
+ void FileSystemAccessedSync(int render_process_id,
+ int render_frame_id,
+ const GURL& url,
+ bool blocked_by_policy,
+ IPC::Message* reply_msg) override;
#if defined(ENABLE_PLUGINS)
// content::WebContentsObserver implementation.
- virtual bool OnMessageReceived(
- const IPC::Message& message,
- content::RenderFrameHost* render_frame_host) override;
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message,
+ content::RenderFrameHost* render_frame_host) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
#endif // defined(ENABLE_PLUGINS)
private:

Powered by Google App Engine
This is Rietveld 408576698