Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h
index fdae7d59dc0d702483e68e5ba22e837e89bbada2..9b9dca5949606e71fa3b3b98858e69a6db89aff7 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h
@@ -25,28 +25,24 @@ class ChromeWebViewGuestDelegate : public extensions::WebViewGuestDelegate,
public :
explicit ChromeWebViewGuestDelegate(
extensions::WebViewGuest* web_view_guest);
- virtual ~ChromeWebViewGuestDelegate();
+ ~ChromeWebViewGuestDelegate() override;
// WebViewGuestDelegate implementation.
- virtual double GetZoom() override;
- virtual bool HandleContextMenu(
- const content::ContextMenuParams& params) override;
- virtual void OnAttachWebViewHelpers(content::WebContents* contents) override;
- virtual void OnDidAttachToEmbedder() override;
- virtual void OnDidCommitProvisionalLoadForFrame(bool is_main_frame) override;
- virtual void OnDidInitialize() override;
- virtual void OnDocumentLoadedInFrame(
+ double GetZoom() override;
+ bool HandleContextMenu(const content::ContextMenuParams& params) override;
+ void OnAttachWebViewHelpers(content::WebContents* contents) override;
+ void OnDidAttachToEmbedder() override;
+ void OnDidCommitProvisionalLoadForFrame(bool is_main_frame) override;
+ void OnDidInitialize() override;
+ void OnDocumentLoadedInFrame(
content::RenderFrameHost* render_frame_host) override;
- virtual void OnGuestReady() override;
- virtual void OnGuestDestroyed() override;
- virtual void OnSetZoom(double zoom_factor) override;
- virtual void OnShowContextMenu(
- int request_id,
- const MenuItemVector* items) override;
+ void OnGuestReady() override;
+ void OnGuestDestroyed() override;
+ void OnSetZoom(double zoom_factor) override;
+ void OnShowContextMenu(int request_id, const MenuItemVector* items) override;
// ZoomObserver implementation.
- virtual void OnZoomChanged(
- const ZoomController::ZoomChangedEventData& data) override;
+ void OnZoomChanged(const ZoomController::ZoomChangedEventData& data) override;
extensions::WebViewGuest* web_view_guest() const { return web_view_guest_; }

Powered by Google App Engine
This is Rietveld 408576698